• State Not Answered
  • Locked Locked
  • Replies 17 replies
  • Subscribers 21 subscribers
  • Views 4884 views
  • Users 0 members are here
2025 survey

We are running a survey to help us improve the experience for all of our members. If you see the survey appear, please take the time to tell us about your experience if you can.

Options
Related
How was your experience today?
This discussion has been locked.
You can no longer post new replies to this discussion. If you have a question you can start a new discussion

HELP:How to define a complex MACRO?

Maggie Chen

I had searched in the Discussion Forum for the whole moring but I couldn't find the right way to solve the problem I met,so I send this message hoping you guys can help me!Thanks in advance:-)My problem is as follows:

1.I want to define a macro,which is similar like function.It will be used in my communction interrupt service routine(so you can see that why I don't choose to call a function to realize it)

2.here's the definition of this macro:
#define Macro_TestRxEnd(sbit Header_flag,uchar Header,uchar Tailer) \
{ \
Return_flag = 0; \
if (!Header_flag) \
{ \
if (Rxbuf == Header) \
{ \
Header_flag = 1; \
ptRxBuf++; \
} \
else \
{ ptRxBuf = xBuf; } \
else \
{ \
if (Rxbuf == Tailer) \
{ Return_flag = 1; } \
}

3.then the compile result is :
Error C304: Bad Macro Parameter List

so can anyone help me find out the right way to define such a long macro? I'm waiting for your good ideas earnestly!

Parents
  • 0 in reply to Andy Neil

    "...all messages have the same format, I presume:
    1. A header;
    2. a body;
    3. a tail.
    I would structure the ISR on this basis..."

    Something like this:

    void isr( void )
{
    static bit           in_message = 0; // Set to 1 after a header has been detected;
                                         // Cleared to 0 when a trailer is detected;
                                         // Thus it indicates when we are within the body
                                         // of a message

    static unsigned char msg_type;       // Records the last-received header;
                                         // So, when in_message is set, this indicates the
                                         // type of message currently in progress.

    if( in_message )
    {   // We're within the body of a message;
        // ie, a Header has previously been detected.
        // Check if this is now the end of the message
        if( Rxbuf == Tailer )
        {   // It's the end of the message
            in_message = 0;
        }
        else
        {   // It's not the end of the message;
            // handle a message-body character
            // (possibly depending on msg_type?)
        }
    }
    else
    {   // Not currently within the body of a message;
        // Check if this is a header
        switch( Rxbuf )
        {
            case A_Header:  // It's the start of an "A" frame:
                            in_message = 1;
                            msg_type   = Rxbuf;
                            break;
            case B_Header:  // It's the start of a "B" frame:
                            in_message = 1;
                            msg_type   = Rxbuf;
                            break;
            case C_Header:  // It's the start of an "C" frame:
                            in_message = 1;
                            msg_type   = Rxbuf;
                            break;
            default:        // Not the start of a frame - Do nothing!
                            break;
        }
    }
}
    Not complete, and room for some optimisation, but you get the idea...?

Reply
  • 0 in reply to Andy Neil

    "...all messages have the same format, I presume:
    1. A header;
    2. a body;
    3. a tail.
    I would structure the ISR on this basis..."

    Something like this:

    void isr( void )
{
    static bit           in_message = 0; // Set to 1 after a header has been detected;
                                         // Cleared to 0 when a trailer is detected;
                                         // Thus it indicates when we are within the body
                                         // of a message

    static unsigned char msg_type;       // Records the last-received header;
                                         // So, when in_message is set, this indicates the
                                         // type of message currently in progress.

    if( in_message )
    {   // We're within the body of a message;
        // ie, a Header has previously been detected.
        // Check if this is now the end of the message
        if( Rxbuf == Tailer )
        {   // It's the end of the message
            in_message = 0;
        }
        else
        {   // It's not the end of the message;
            // handle a message-body character
            // (possibly depending on msg_type?)
        }
    }
    else
    {   // Not currently within the body of a message;
        // Check if this is a header
        switch( Rxbuf )
        {
            case A_Header:  // It's the start of an "A" frame:
                            in_message = 1;
                            msg_type   = Rxbuf;
                            break;
            case B_Header:  // It's the start of a "B" frame:
                            in_message = 1;
                            msg_type   = Rxbuf;
                            break;
            case C_Header:  // It's the start of an "C" frame:
                            in_message = 1;
                            msg_type   = Rxbuf;
                            break;
            default:        // Not the start of a frame - Do nothing!
                            break;
        }
    }
}
    Not complete, and room for some optimisation, but you get the idea...?

Children