Hello all, It has been rather quiet lately so let me help us out of the sleep slumber!
"Pino" was an idiot. Every time he checked something into the SVN database, the comments were accompanied by an annoying smiley or a "..." or ":-)" (I'd rather place a ":-0" instead. Soon you will see why). If you believe Erik's comments regarding the possible relation between the appearance of source code and its quality, this guy should have made impeccable code. He should have won the miss universe competition for source code. I'm serious. unfortunately, appearances can be deceiving! It all started when he changed some code to support his so called "ground drive" procedure. instead of using the existing code which has been in use for years and is indeed not the best looking and efficient but works well, he changed the low level procedures that affect the way hardware timers are read to evaluate RPM (I did not fully understand then what he did, and was not asked to review the changes. Nobody was!). Weeks went by, until the first problem reports came in. "Your (hence: mine) RPM reading are going nuts. they are fluctuating constantly". The code in question was not finished, but it ran before without trouble. After concluding that it cannot be my code, I measured the output signals that traveled to the hydraulic valve using a scope, made a recording and saw that the PWM signal was unstable. Then I reverter the changes made by "Pino"'s, and that was an (un)pleasant surprise! First of all, he did not know the hardware. He added an ISR without having set the respective register that would invoke an interrupt. He also referred to the wrong hardware timer to manage (what he thought) was his RPM measurement. He did not realize that he was ruining the entire module. Recently he destroyed the entire throttling system (it works on some machines, but not on others). Maybe that was fixed in the mean time - but that does not change my conclusion - Reckless at best! From this day on, I nickname his "demolition man".