• State Not Answered
  • Locked Locked
  • Replies 2 replies
  • Subscribers 21 subscribers
  • Views 1196 views
  • Users 0 members are here
2025 survey

We are running a survey to help us improve the experience for all of our members. If you see the survey appear, please take the time to tell us about your experience if you can.

Options
Related
How was your experience today?
This discussion has been locked.
You can no longer post new replies to this discussion. If you have a question you can start a new discussion

error 253

lily lily

#include <reg52.h>
unsigned char chrState;
unsigned char chrDate[6];//year, month, date, hour, minute, second
unsigned char idata chrPlace;

void main()
{
unsigned char chrTemp;
do
{
do
{

}while(1);
switch (chrState)
{
case 1:
{
if (chrTemp<11)
{
switch (chrPlace)
{
case 8:
{
chrDate[0]%=10;
}
break;
case 7:
{
chrDate[0]/=10;
}
break;
case 6:
{
chrDate[1]%=10;
}
break;
case 5:
{
chrDate[1]/=10;
}
break;
case 4:
{
chrDate[2]%=10;
}
break;
case 3:
{
chrDate[2]/=10;
}
break;
case 2:
{
chrDate[3]%=10;
}
break;
case 1:
{
chrDate[3]/=10;
}
break;
case 16:
{
chrDate[4]%=10;
}
break;
case 15:
{
chrDate[4]/=10;
}
break;
case 14:
{
chrDate[5]%=10;
}
break;
case 13:
{
chrDate[5]/=10;
}
break;
default:
break;
}
}
}
break;
case 2:
{

}
break;
}
}while(1);
}

Parents
  • 0 in reply to Andy Neil

    You're missing some code:

    do
{
    do
    {

    }while(1);

...

    Most of the posted sample is unreachable.

    I'd also suggest that the code might be a little more compact and readable if you set an index and an operator, so that it all collapses into

    typedef enum {Mod, Div } Operators;

Operators op = SomeFunctionOfState (chrState);
U8 i = SomeOtherFunctionOfState (chrState);

if (op == Mod)
    {
    chrDate[i] %= 10;
    }
else
    {
    chrDate[i] /= 10;
    }

Reply
  • 0 in reply to Andy Neil

    You're missing some code:

    do
{
    do
    {

    }while(1);

...

    Most of the posted sample is unreachable.

    I'd also suggest that the code might be a little more compact and readable if you set an index and an operator, so that it all collapses into

    typedef enum {Mod, Div } Operators;

Operators op = SomeFunctionOfState (chrState);
U8 i = SomeOtherFunctionOfState (chrState);

if (op == Mod)
    {
    chrDate[i] %= 10;
    }
else
    {
    chrDate[i] /= 10;
    }

Children
No data