Simulator issue with printf?

THIS IS CODE MY FRIEND GAVE ME

HE SAID HE GOT IT FROM GOOGLE AND IT WORKS BUT NOT CORRECTLEY

int printbcd(int value)
{
  printf("%x",binerytobcd(value));
}

int binerytobcd(int binery)
{
  int frpol;    /* framing p?? */
  int bcd;      /* working sum */

  for( frpol = 0 ; frpol < 7 ; frpol = frpol + 1)
  {
    if (binery<2)    /* is binery a binery number*/
     bcd = bcd + 1;     /* change bcd to add it */

    binery = binery - 2; /* do next number */
  }

  return ( bcd % 255 ); /* get rid of last bit */
}

I TRY AND I DO NOT SEE CORRECT ANSWER

CHECK CODE AND SAY WHAT IS WRONG

THIS IS CODE MY FRIEND GAVE ME

HE SAID HE GOT IT FROM GOOGLE AND IT WORKS BUT NOT CORRECTLEY

int printbcd(int value)
{
  printf("%x",binerytobcd(value));
}

int binerytobcd(int binery)
{
  int frpol;    /* framing p?? */
  int bcd;      /* working sum */

  for( frpol = 0 ; frpol < 7 ; frpol = frpol + 1)
  {
    if (binery<2)    /* is binery a binery number*/
     bcd = bcd + 1;     /* change bcd to add it */

    binery = binery - 2; /* do next number */
  }

  return ( bcd % 255 ); /* get rid of last bit */
}

I TRY AND I DO NOT SEE CORRECT ANSWER

CHECK CODE AND SAY WHAT IS WRONG

"CHECK CODE AND SAY WHAT IS WRONG"

First, why do you and your friend think it is not correct? What have you observed?

"... WORKS BUT NOT CORRECTLEY"

How can something WORK and not be CORRECT?

PLEASE

YOU SEE THE PROBLEM IN MY CODE?

IT SOMETIMES GIVES A GOOD ANSWER SO I THINK THERE IS ONLY A LITTLE PROBLEM

WE NEED THE ANSWER 100% CORRECT AND QUIKCLY

"YOU SEE THE PROBLEM IN MY CODE?"

For starters, when (binery<2) is true, what is the purpose of incrementing uninitialized bcd?

The code is a ripe steaming pile of fecal matter. You should have recognized it as such, not asked about it here, and moved on to the next candidate routine for consideration.

100% BAD

I TRY TO INITILISE BCD BUT NOW I NEVER GET THE GOOD ANSWER SO I THINK THAT IS NOT THE PROBLEM

I GO BACK TO FIRST CODE AND SOMETIMES GET GOOD ANSWER WHICH IS BETTER

WHAT ELSE CAN BE WRONG?

"WHAT ELSE CAN BE WRONG?"

The code in its entirety! Move on to the next candidate code.

By the way, you originally said you wanted to print a BCD value. To us, that means that the value is already in (packed) BCD and you want to print it as ASCII digits. Why do you even care about binary to BCD conversion?

"I TRY TO INITILISE BCD BUT NOW I NEVER GET THE GOOD ANSWER SO I THINK THAT IS NOT THE PROBLEM"

OK then. Use uninitialized wherever the mood strikes you. The rest of us don't do that because it yields incorrect results, so we are in no position to be able to help you. I think you should be asking for help elsewhere; a place where using uninitialized variables is acceptable and gives correct results. That place is not here.

So, to conclude:

1) You have hijacked a thread (actually at least two threads).

2) You like to SCREAM in threads.

3) You like to constantly repeat your questions.

4) You like to formulate your questions as requests.

5) You don't know what problem you want to solve - hence the incorrect query about printing BCD numbers.

6) This is a school assignment.

7) Your current bet is some rubbish code you have got from a friend.

8) You think uninitialized variables are the way to go, because the broken code looks like it produces sligthly better results then.

9) You refuces to sit down with a pen and paper and figure out what to do, and how to do it.

10) You think cheating in an acceptable way of passing school assignments.

Exactly what do you expect us to do about this mess? receive the full unabrigated school assignment and write a fully working and perfectly documented program to solve the task for you? Would that make you a better student - or just a student that have cheated?

Note, that by helping you cheat on school assignments, that makes us cheaters too. If I just knew exactly what the task is, I could probably code and test the code within 5 minutes. Hence, if you participated on the lessons, you should be able to solve the problem (without Google) within an hour.

How about picking up the school books and for cnce spend some time reading them. Yes, I know that this will take a _huge_ amount of time. It is quite obvious that you will have to open the books at an very early page. Variables are treated very early. Uninitialized variables are definitely discussed very thoroughly!

This is a _trivial_ assignment, so do spend some time solving it yourself, instead of almost killing yourself trying to find the best way to cheat.

By the way - you do know that some teachers actually keeps track of Internet forums, to see which students are busying themselves with cheating? They don't have to read all posts on all forums in this world: The advantage of Google, is that they can google for people cheating...

I HAVE NOW GOT BETTER CODE WITH INITIALOIZED DATA AND IT IS NOW WORKING BETTER

IT WORKS WITH MOST NUMBERS 0 TO 99
BUT IT DOES NOT WORK WITH NUMBERS 100 to 255

THIS MUST WORK 100% TODAY AND PRINT BCD NUMBERS

WHAT IS WRONG?

int printbcd(int value)
{
  printf("%x",binerytobcd(value));
}

int binerytobcd(int binary)
{
  int bcd;      /* answer */

  bcd = 0;      /* initilase variable */

  while (binary > 10) /* while binary is more than 10 */
  {
    bcd = bcd + 16;       /* change bcd */
    binary = binary - 10; /* change binary */
  }

  while (binary > 0)   /* while binary is greater than 1 */
  {
    bcd = bcd + 1;    /* chainge bcd */
    binary = binary - 1; /* change binary */
  }

  return bcd;        /* result */
}

You are still SHOUTING!

Do not write in ALL CAPITALS!

"WHAT IS WRONG?"

1) The code is lousy!

2) You still haven't learned what BCD numbers are!

Try one more time to google for BCD numbers. How can you know when a solution works or not, if you don't even know what the expected output result is?

By the way: Please post your address, and you'll get a visitor that will rip the caps-lock key from your keyboard - and every keyboard within a 100m radius... Upper-case text represents shouting, as already told a number of times in this thread. Are you dense?

I LOOK ON GOOGLE FOR BCD AGAIN AND FOUND DATA ON PACKET BINARY CODED DECIMAL

I DO NOT UNDERSTAND HOW TO PACKET DATA INTO BYTE

ANYONE KNOW?

THE CODE CAM FROM A FREIND WHO SAYS IT WORKS BUT I TRY WITH (IE) 120 BUT IT DOES NOT PRINT 120

I NEED TO GET CODE WORKING

PLEASE WHAT IS WRONG?

Which part of "do not write in ALL-CAPITALS" do you not understand?

I mean, "do not write in ALL-UPPERCASE"

I DO NOT UNDERSTAND HOW TO PACKET DATA INTO BYTE

ANYONE KNOW?

What would be the point in telling you?
You clearly aren't listening to what you're being told!

How many times does "Don't Shout" have to be said to you before you will stop shouting??

I will give you some tips if you will stop shouting.