• State Not Answered
  • Locked Locked
  • Replies 8 replies
  • Subscribers 21 subscribers
  • Views 3283 views
  • Users 0 members are here
2025 survey

We are running a survey to help us improve the experience for all of our members. If you see the survey appear, please take the time to tell us about your experience if you can.

Options
Related
How was your experience today?
This discussion has been locked.
You can no longer post new replies to this discussion. If you have a question you can start a new discussion

Collect 8bit data from IO ports

Sheng Chao Wong

I'm having a problem with collecting data from Port1. the variable ValueX has a value of FF, regardless of my input through the IO pins.With here i enclose partial of my code, any help or advice is highly appreciated, thank you!

sbit P1^0 BIT0; //these 8 ports will be input
.
.
.
.
sbit P1^7 BIT7;

signed char ValueX = 0x00;
.
.
void ReadValue(void);
void main()
{
P1 = 0xFF; //port set high to activate as input
.
.
}

void ReadValue(void) interrupt 0 using 0
{
 .
 .
 .
 ValueX = ValueX | BIT0;
 ValueX = (ValueX <<1) | BIT1;
 ValueX = (ValueX <<1) | BIT2;
 ValueX = (ValueX <<1) | BIT3;
 ValueX = (ValueX <<1) | BIT4;
 ValueX = (ValueX <<1) | BIT5;
 ValueX = (ValueX <<1) | BIT6;
 ValueX = (ValueX <<1) | BIT7;
}
}
i'm sure tat my setting for this ISR works because i had other function inside this ISR that works. But the ValueX doesn't seems to change. It always maintain the value FF. Any help, please.. Thanks

Parents
  • 0 in reply to Sheng Chao Wong

    Possibly this is your problem:

    void ReadBits (void) interrupt 0 using 0
    I have not taken a look to see what effect this will have, but here are some things you might like to check.

    Generally, the main() thread is executed using register bank 0 and a different register bank is used for each priority level of ISR.

    However, you have this interrupt using register bank 0 too. It is possible that the compiler will assume that it can safely switch to register bank 0 without saving any of the registers of main(). Chaos results.

    Try:
    void ReadBits (void) interrupt 0 using 1

Reply
  • 0 in reply to Sheng Chao Wong

    Possibly this is your problem:

    void ReadBits (void) interrupt 0 using 0
    I have not taken a look to see what effect this will have, but here are some things you might like to check.

    Generally, the main() thread is executed using register bank 0 and a different register bank is used for each priority level of ISR.

    However, you have this interrupt using register bank 0 too. It is possible that the compiler will assume that it can safely switch to register bank 0 without saving any of the registers of main(). Chaos results.

    Try:
    void ReadBits (void) interrupt 0 using 1

Children
No data