This discussion has been locked.
You can no longer post new replies to this discussion. If you have a question you can start a new discussion

good code bad answer

my code is 110% correct; eg no errors and runs properly. see.

int _val;

int myfunc2(int val)
{
  _val = val;
   return _val;
};

int Bar(int val)
{
  return _val + val + 1;
};

void myfunc1(int val)
{
  _val += Bar(val);
};

etc
etc
etc

it doesnt give me the right answer sometime.

HEEEEEEEELLLLLLLPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPP

Parents
  • Watchout for functions modifying global variables and called as part of expressions that contains same global variables.

    You have to look out for evaluation order problems.

    And depending on your code, you may have to consider aliasing problems too - multiple access ways to the same variable making the compiler fail to notice that one access way changes the variable while the compiler sees the other access way and think the variable must be unchanged.

    Think twice about your use of global variables.

Reply
  • Watchout for functions modifying global variables and called as part of expressions that contains same global variables.

    You have to look out for evaluation order problems.

    And depending on your code, you may have to consider aliasing problems too - multiple access ways to the same variable making the compiler fail to notice that one access way changes the variable while the compiler sees the other access way and think the variable must be unchanged.

    Think twice about your use of global variables.

Children