• State Not Answered
  • Locked Locked
  • Replies 13 replies
  • Subscribers 21 subscribers
  • Views 2394 views
  • Users 0 members are here
2025 survey

We are running a survey to help us improve the experience for all of our members. If you see the survey appear, please take the time to tell us about your experience if you can.

Options
Related
How was your experience today?
This discussion has been locked.
You can no longer post new replies to this discussion. If you have a question you can start a new discussion

using jb of a unsigned char in c

heyvaert vincent

hello,
I would like to do a bit test of a unsigned char variable. It's like a jb in assembler.

here is my code in c.


unsigned char displ;
unsigned char display3 = 0xA8;
unsigned char i;
sbit display_data = P1^0;

displ = display3;
for (i=0; i<7; i++) {
        if (displ^0 == 1){
        display_data = 0;
        }
        else {
        display_data = 1;
        }
        displ>>=1;
}


I don't have any warning or error, but the result of test is wrong.
is it possible to do in c?

tkx.

Parents
  • 0 in reply to Dan Henry

    This is not quite as K&R would have it:

    for (i=0; i<7; i++) {
        if (displ^0 == 1){
        display_data = 0;
        }
        else {
        display_data = 1;
        }
        displ>>=1;
}


    "True" K&R style would be:

    for (i=0; i<7; i++) {
        if (displ^0 == 1){
                display_data = 0;
        }
        else {
                display_data = 1;
        }
        displ>>=1;
}


    The "controlled" lines are indented relative to the "controlling" lines.

Reply
  • 0 in reply to Dan Henry

    This is not quite as K&R would have it:

    for (i=0; i<7; i++) {
        if (displ^0 == 1){
        display_data = 0;
        }
        else {
        display_data = 1;
        }
        displ>>=1;
}


    "True" K&R style would be:

    for (i=0; i<7; i++) {
        if (displ^0 == 1){
                display_data = 0;
        }
        else {
                display_data = 1;
        }
        displ>>=1;
}


    The "controlled" lines are indented relative to the "controlling" lines.

Children
  • 0 in reply to Andy Neil

    well, fortunately, while we have to adhere to the syntax, we are free to improve on the style.

    I have a lingering suspicion that K&R are, at least partially, responsible for much of the "elegant" C that abounds

    Erik

    PS if anyone does not get that I am fastidious when stating "elegant" the are now told.