Problem in Interuppt Program

Rajeesh:

I can't help but notice that you don't put any comments in your code (or you feel like you need to take them out before posting).

I think that many folks put in comments to tell others what the code does. However, I believe it is equally important to tell reviewers what you WANTED the code to do.

It would be considerably easier if you put in comments to that effect. Otherwise, how could anyone tell what your desire was/is?

Best Regards,

-=Rich=-

Rajeesh:

I can't help but notice that you don't put any comments in your code (or you feel like you need to take them out before posting).

I think that many folks put in comments to tell others what the code does. However, I believe it is equally important to tell reviewers what you WANTED the code to do.

It would be considerably easier if you put in comments to that effect. Otherwise, how could anyone tell what your desire was/is?

Best Regards,

-=Rich=-

void timer_routine(void) interrupt 7  using 2
{
    EA=0;        //disable all interrupt
    CL=0x5F;     //loading 0xfo5f to pca counter
    CH=0xF0;
    CCF1=0;      //clearing capture compare flag
    CF=0;        //clearing pca counter overflow flag
    P2_6=~P2_6;     //complementing the portpin
    EA=1;           //enable all interrupt
}

void main()
{


                IEN0=0xC0;  //enable all interupt and pca interupt
                TMOD |=0x02; //set timer0 as timer
                TL0=0x00;   //reload timer value as 0x1800
                TH0=0x18;
                TF0=0;
                CMOD=0x05;  //select timer 0 as pca clock and enable pca capture interupt
                CCAP1L=0x0A; //filling non zero values
                CCAP1H= 0x4F;
                CCAPM1=0x49;  //setting ecom1 and mat1 and eccf1bits to use as software timer and enabling capture interupt
                CL=0x5F;   // filling the pca timer
                CH=0xF0;
                CCAP1L=0xFF; //filling the capture ,compare modules
                CCAP1H= 0xFF;
                TR0=1;    //run timer0
                CR=1;    //run pca timer
                P2_6=0;



                while(1);

}

Could you tell me this:

the advanced 8051 instruction set that you say works on uvision2?

rgds,

you were told:
There are advanced 8051.
Please go through the registers of ED2. that, cutting it in cardborad, should have been the SFRs of ED2

you ask
the advanced 8051 instruction set that you say works on uvision2?
1) who said ANYTHING about "instruction set"
2) there is no "advanced instruction set"
3) if you took the time to do what Rajesh suggested BEFORE posting another ELEMENTARY question you would not need to ask.

Erik

Read "the bible" 5 times or more, then read the ED datasheet 5 times or more, then when you have a question that can not be figured out by a 5 year old come back.

The comments are an improvement, but it's still a mass of magic numbers; eg,

CCAPM1=0x49;  //setting ecom1 and mat1 and eccf1 bits
              //to use as software timer and enabling capture interupt

Are you sure that 0x49 is the right magic number for that particular set of bits? Wouldn't it be much clearer (and, hence, more maintainable) to define symbolic constants and write, say:

CCAPM1 = ECOM1 + MAT1 + ECCF1; //to use as software timer and enabling capture interupt

"in all EEPROM programs I have used EA=0 and EA=1 at begining and end of program."

What do you mean by that?
Are you confusing "program" with "function"?

"If there is any suggestion"

If your timer code works alone, and then stops when integrated with something that's fiddling with the EA flag, I think there could be a clue there somewhere...

Somebody like who 's got an eye for detail could fix up the error..

you take a route very populat roday.

"Somebody ... could fix up the error

Why can that 'somebudy" not be you. Or is it you are very good at requesting "somebody" to do something (expecially do it for free), but see no reason to do anything yourself but request "somebody" to do it.

Send me check for a consultant fee and I will gladly take the time to work through incomplete questions, uncommented code, vague descriptions etc trying to figure out what exactly is ment. For free I, find it reasonable to request. that all questions be answered in a clear, understandable way and code is formatted and commented.

Erik

For free I, find it reasonable to request. that all questions be answered in a clear, understandable way and code is formatted and commented.

You expect that, do you? Well, you got it here:

http://www.keil.com/forum/docs/thread8551.asp

yet even then you either couldn't be bothered to read or were incapable of understanding the responses.

yet even then you either couldn't be bothered to read or were incapable of understanding the responses.

I read every response and, to the best of my ability, tried to understand them, if I did not I asked for clarification.

I do believe that I did 'understand' and did reply "I save some confusion and add some (the added parantheses), albeit less, I do not think that is worth it".
In another reply I staed "I do not see it feasible to look at anything else than the actual file you are to add the changes to"

If, in any suggestion, the are no parantheses etc. added NOTHING BUT a 'preface' (e.g. TYPRA) to the lines, AND it does not involve looking at another file than the one you want to modify, then you are right that I "were incapable of understanding" and would appreciate it if you could explain (in that thread, please).

Erik

so wat do you charge,

assure that you WILL,