This discussion has been locked.

You can no longer post new replies to this discussion. If you have a question you can start a new discussion

Function editor

Hello,

I'm currently using uVision 2.33. I've written the following function in the function editor to simulate an RC5 signal which I want to detect on P1.1:

define button "Start P1.1 Toggle", "p11_toggle()"
define button "Stop P1.1 Toggle" , "signal kill p11_toggle"

signal void Generate0()
{
    P1 &= ~0x02; /* pull T2EX(P1.1) low and generate interrupt */
    twatch( 889 );
    P1 |= 0x02;  /* pull T2EX(P1.1) high */
    twatch (889);
}

signal void Generate1()
{
    P1 |= 0x02;  /* pull T2EX(P1.1) high */
    twatch( 889 );
    P1 &= ~0x02; /* pull T2EX(P1.1) low and generate interrupt */
    twatch (889);
}

signal void p11_toggle()
{
    while (1)
    {
        // Bit1: start
        Generate1();
        // Bit2: indication
        Generate1();
        // Bit3: toggle
        Generate0();
        // Bit4: system5
        Generate0();
        // Bit5: system4
        Generate0();
        // Bit6: system3
        Generate0();
        // Bit7: system2
        Generate0();
        // Bit8: system1
        Generate1();
        // Bit9: command6
        Generate1();
        // Bit10: command5
        Generate0();
        // Bit11: command4
        Generate0();
        // Bit12: command3
        Generate0();
        // Bit13: command2
        Generate1();
        // Bit14: command1
        Generate0();
        swatch( 1 );
    }
}

If I compile this script, I don't get a compilation or warning from the function editor.

However, when I run my program and activate the toggling functionality on P1.1 via the button "Start P1.1 Toggle", I get the following error message:

*** function 'p11_toggle', error 99, line 27: signal() already activated
p11_toggle()
*** error 99: signal() already activated

I know that the functions Generate1() and Generate0() are called more than once without first killing and then re-calling them, but what is the alternative? How can I 'call' more than once the same function from within another function?

Also, when I put the funcions Generate1() and Generate0() at the end of the script, the compiler doesn't complain, but when I load this script, I get the following error:

*** error 34, line 9: undefined identifier

Why does the script compiler not inform me about this 'mistake'?

Rgds,

--Geert

Parents

0 Jon Ward over 22 years ago in reply to Geert Vancompernolle

I can think of several ways to do this. The first one is a simple substitution. Just put the Generate0 and Generate1 functions in-line:

/* Gen 0 on P1.1:  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889); */
/* Gen 1 on P1.1:  P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889); */


signal void p11_toggle (void)
{
while (1)
  {
  // Bit1: start
  P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889);

  // Bit2: indication
  P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889);

  // Bit3: toggle
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit4: system5
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit5: system4
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit6: system3
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit7: system2
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit8: system1
  P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889);

  // Bit9: command6
  P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889);

  // Bit10: command5
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit11: command4
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit12: command3
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit13: command2
  P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889);

  // Bit14: command1
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  swatch( 1 );
  }
}

The second way allows you to pass an unsigned integer containing the bits to send. A loop index scans the bits in the value and transmits the appropriate signal. Of course, I defaulted to a 14-bit value. However, if the length changes, you can simply pass the length to this function as well.

signal void send_p11_info (unsigned int val)
{
unsigned char i;

while (1)
  {
  for (i = 0; i < 14; i++)
    {
    if (val & (1 << i))   /* Send 1 */
      {
      P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889);
      }
    else                  /* Send 0 */
      {
      P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);
      }
    }

  swatch( 1 );
  }
}


/*** Assign this function call to a button or whatever ***/

send_p11_info (0x1183);


/* 0x1183 = 01 0001 1000 0011 = the values transmitted by the original signal */

Jon

Reply

0 Jon Ward over 22 years ago in reply to Geert Vancompernolle

I can think of several ways to do this. The first one is a simple substitution. Just put the Generate0 and Generate1 functions in-line:

/* Gen 0 on P1.1:  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889); */
/* Gen 1 on P1.1:  P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889); */


signal void p11_toggle (void)
{
while (1)
  {
  // Bit1: start
  P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889);

  // Bit2: indication
  P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889);

  // Bit3: toggle
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit4: system5
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit5: system4
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit6: system3
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit7: system2
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit8: system1
  P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889);

  // Bit9: command6
  P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889);

  // Bit10: command5
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit11: command4
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit12: command3
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  // Bit13: command2
  P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889);

  // Bit14: command1
  P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);

  swatch( 1 );
  }
}

signal void send_p11_info (unsigned int val)
{
unsigned char i;

while (1)
  {
  for (i = 0; i < 14; i++)
    {
    if (val & (1 << i))   /* Send 1 */
      {
      P1 |= 0x02; twatch (889); P1 &= ~0x02; twatch (889);
      }
    else                  /* Send 0 */
      {
      P1 &= ~0x02; twatch (889); P1 |= 0x02; twatch (889);
      }
    }

  swatch( 1 );
  }
}


/*** Assign this function call to a button or whatever ***/

send_p11_info (0x1183);


/* 0x1183 = 01 0001 1000 0011 = the values transmitted by the original signal */

Jon

Children

0 Geert Vancompernolle over 22 years ago in reply to Jon Ward

The second one is a real nice solution. Thanks for this input, Jon!

Rgds,

--Geert
Cancel
Vote up 0 Vote down

Cancel