We are running a survey to help us improve the experience for all of our members. If you see the survey appear, please take the time to tell us about your experience if you can.
i am working on 89c51 uc is this code correct for rc car.
#include<stdio.h> #include<Regx51.h>
sbit t0=P1^0; sbit t1=P1^1; sbit t2=P1^2; sbit t3=P1^3; sbit t4=P2^0; sbit t5=P2^1; sbit t6=P2^2; sbit t7=P2^3; sbit t8=P2^4; sbit t9=P1^5; sbit t10=P1^6; sbit t11=P1^7; sbit t12=P2^5; sbit t13=P2^6; sbit t14=P2^7;
void main() {
t9=t10=t11=t12=t13=t14=0; t0=1; t1=1;t2=1;t3=1;//t3=t2=t1=t0=1; for(; ;) { l1: if(t0==0) //left { t4=1; t5=1; t6=t7=t8=0; goto l1; } l2:if(t1==0) //right { t6=1; t7=1; t4=t5=t8=0; goto l2; } l3:if(t2==0) //forward { t7=1; t4=t5=t6=t8=0; goto l3; } l4:if(t3==0) //reverse { t8=1; t4=t5=t6=t7=0; goto l4; }
} }
plz correct the code
that is asking too much when you can neither spell 'please' nor read instructions (re posting code).
BTW from what I can gather from the faultily posted garbage, it is not code but scribbles. Code has comments,
Erik
Erik,
How I'd like you to pass comment on what my employer has recently given me. Very few comments, incorrect comments, irrelevant comments, plenty of gotos, magic values all over the place, a lot of these magic values into arrays containing a multitude of different length elements (plenty of them logically unrelated), no passing of parameters or return of values to/from functions, virtually no local variables, plenty of global variables, few assumptions about ordering of variables in memory. I've seen a lot of bad code during my career, but this is the pits!
AJAU DEV = a deja-vu ?
How I'd like you to pass comment on what my employer has recently given me. Very few comments, incorrect comments, irrelevant comments, plenty of gotos, magic values all over the place, a lot of these magic values into arrays containing a multitude of different length elements (plenty of them logically unrelated), no passing of parameters or return of values to/from functions, virtually no local variables, plenty of global variables, few assumptions about ordering of variables in memory. I've seen a lot of bad code during my career, but this is the pits
I call that "job security". Had there been no messes, there would be no work for cleaners.
No, not job security. Just too many out there bumbling at what they do. Hacking until it works. And not hacking in the good sense.