Hello good and kind people.
I have been told to put some code into Keil MDK ARM. I have been told it works. Here is an extract.
#define loop } long ratishmy(char **IPtab) { char mystring[10]; int temp1; char temp2; char temp3; long ans; temp1 = 2496 temp2 = 0 while ( temp2 < 76 ) { mystring = IPtab(temp2); temp3 = 1; while ( temp3 < 11 ) { CONFIG(temp1) = mystring[temp2][temp3]; temp3 = temp3 + 1; temp1 = temp1 + 1; loop temp2 = temp2 + 1; loop }
What is your opinion of it? I want to either rip it up and start again or if they won't let me do that I might run away from it.
No. As I thought I explained, I have been given this code by my manager and told to put it into a new project using Keil MDK ARM. I am not a dumb-nut student! If you were told to do what I've been told to do, would you do it, try to persuade them to let you improve it or run away?
I'd run away from such a boss! Man, what a mess. Just redo it from scratch. What is this?!
It's for some touch screen configuration software. I've spoken to a few other guys in the department and they can't see anthing wrong with it. I've been starting to wonder whether I'm being too critical. This is my probationary period at this job and I need it, but wonder whether I need it this much.
Can you program in C? Are you comfortable with these statements?
mystring = IPtab(temp2);
and
CONFIG(temp1) = mystring[temp2][temp3];
That code must be a contender for most stupid ways to abuse a programming language.
I love } replaced with a #define. I love while loops to implement for loops. I love the use of temp1, temp2, temp3, ... I love ...
The code stinks. Anyone involved in the production of this code should be moved to some other part of the company. Preferably carrying out the trash or similar.
Yes, I can program in C and I am not comfortable with those statements. I have spoken to the team members here and they say they cannot see anything wrong! What I posted is a cut and paste. It is how I received it! it's making me feel ill.
It must be a test for you. To see how you handle the absurd.