using 89C4051.

Hi,
I am unable to get the detail from your program.Please go through the code I have done.Thanks in advance....

IN ISR
-------------
void timer0_isr(void)
{ while((tick--)!=0)
timer0_isr_go();
TR1=0;
TF1=0;
TR0=TF0=0;
LCD_command(0x01);
} void timer0_isr_go(void)
{ TH0=0x3C;
TL0=0xBA;
} void timer1_isr(void)
{ freq++;
}

IN MAIN PROGRAM
----------------

void measure_freq()
{ unsigned char xx2[5],xx1,xx0[5]; while(1) { LCD_command(0x01); TH0=0x3C; TL0=0xBA; tick=0x20;

freq=0; TH1=0; TL1=0;

TR0=TR1=1; while(TF0!=0) { LCD_command(0x01); timer0_isr(); timer1_isr(); } *xx2=freq; xx1=TH1; *xx0=TL1; n=strlen(xx0); LCD_row1(); print_str_lcd(xx0,n); LCD_row2(); LCD_puts("xx1");

init_serial(); serial_data(); printf ("\nValue of XX2 : %d ",xx2); printf ("\nValue of XX1 : %d ",xx1); printf ("\nValue of XX0 : %d ",xx0);

} }

Hi,
I am unable to get the detail from your program.Please go through the code I have done.Thanks in advance....

IN ISR
-------------
void timer0_isr(void)
{ while((tick--)!=0)
timer0_isr_go();
TR1=0;
TF1=0;
TR0=TF0=0;
LCD_command(0x01);
} void timer0_isr_go(void)
{ TH0=0x3C;
TL0=0xBA;
} void timer1_isr(void)
{ freq++;
}

IN MAIN PROGRAM
----------------

void measure_freq()
{ unsigned char xx2[5],xx1,xx0[5]; while(1) { LCD_command(0x01); TH0=0x3C; TL0=0xBA; tick=0x20;

freq=0; TH1=0; TL1=0;

TR0=TR1=1; while(TF0!=0) { LCD_command(0x01); timer0_isr(); timer1_isr(); } *xx2=freq; xx1=TH1; *xx0=TL1; n=strlen(xx0); LCD_row1(); print_str_lcd(xx0,n); LCD_row2(); LCD_puts("xx1");

init_serial(); serial_data(); printf ("\nValue of XX2 : %d ",xx2); printf ("\nValue of XX1 : %d ",xx1); printf ("\nValue of XX0 : %d ",xx0);

} }

Completely unreadable! Post it formatted!

"Please go through the code I have done."

great work. This is will be the best code for keil c, for generations to come.

just load it up to your mcu and you are done!

keep up the good work.

What, exactly, is your goal here?

You asked: "Can you just give the code (not in detail)"

Per gave you code - not in detail

Then you said: "I am unable to get the detail from your program"

So what, exactly, were you expecting??

If you want to learn embedded programming, then you need to get down and invest time (and, possibly, money) in proper study.

If you don't want to learn embedded programming, then don't mess with it - pay someone to do it properly for you.

But just asking people to give you ready-to-run code is not going to teach you much - if anything.

And expecting them to do it for free is cheeky at best.

Completely unreadable! Post it formatted!

Hi,
I have arranged the program in correct order.Please go through it and let me know the mistakes...

ISR PROGRAM
------------
void timer0_isr(void)
{

while((tick--)!=0)
timer0_isr_go();
TR1=0;
TF1=0;
TR0=TF0=0;
LCD_command(0x01);

}

void timer0_isr_go(void)
{ TH0=0x3C;
TL0=0xBA;
}

void timer1_isr(void)
{ freq++;
}

SUBROUTINE
---------------

void measure_freq()
{

unsigned char xx2,xx1,xx0; while(1)

{

LCD_command(0x01);

TH0=0x3C;

TL0=0xBA;

tick=0x20;

freq=0;

TH1=0;

TL1=0;

TR0=TR1=1;

while(TF0!=0);

LCD_command(0x01);

xx2=freq;

xx1=TH1;

xx0=TL1;

init_serial();

serial_data();

printf ("\nValue of XX2 : %d ",xx2);

printf ("\nValue of XX1 : %d ",xx1);

printf ("\nValue of XX0 : %d ",xx0);

} }

"Please go through the code I have done."

Hi,
Where is the code available which you have done?Please give me he link....

"I have arranged the program in correct order"

But you have not posted it using the correct tags - have you?!

Look at this picture: www.danlhenry.com/.../keil_code.png - it shows you that the instructions are really quite simple and very clearly stated.

You were the one who said, "Please go through the code I have done" - Ashley was just quoting what you said!

Before asking others to "go through" your code, have you gone through it yourself?

Have you followed it through "manually" using pencil & paper?

Have you run it in the Simulator?

www.8052.com/.../169331

www.8052.com/.../92049

Again, if you just want the job done for you, then you must expect to pay for that.

without really looking at your scribbles (code has comments) I see this

void timer1_isr(void)
{
  freq++;
}

you must be measuring and awfully low frequency.

Erik

"you must be measuring and awfully low frequency."

it depends on how low your "low" is.

you must be measuring and awfully low frequency."
it depends on how low your "low" is.

actually, I was wrong, it should have been

"you must be measuring and awfully high frequency. do read the maximun clock rate for the T0 input"

"you must be measuring and awfully high frequency. do read the maximun clock rate for the T0 input"

I fail to see how the "high" or "low" limit would have anything to do with the particularly piece of code you were referencing, particularly when you are talking about T0 (when T1 is counting the pulses).

the code wouldn't work, but that's for other reasons.

if you can't see it in the 'code', forget it

Erik

"if you can't see it in the 'code', forget it"

sounds like you didn't understand why you objected to his code.

per listed out a fairly good approach to code this.

in general:

1) you will need to put a timer into its counter mode. in its isr, you will need to increment a variable to create a software multi-byte counter. for example, in this case, your TH1:TL1 form a 16-bit counter and freq:TH1:TL1 form a 32 bit counter if freq is a 16-bit type.

your frequency count is essentially freq:TH1:TL1 at end of the counting interval

2) you will need to put another timer into its timer mode. this timer will stop the counter mentioned above. depending on the frequency you are counting, you can use isr or no isr for this timer. and how long you set the interval to depends on the frequency you are counting.

that's pretty much all you need for this task. it is a very simple coding job.

} void timer1_isr(void)
{ freq++;
}

will count for every 64k pulses\

Erik