• State Not Answered
  • Locked Locked
  • Replies 11 replies
  • Subscribers 22 subscribers
  • Views 1662 views
  • Users 0 members are here
Options
Related
How was your experience today?
This discussion has been locked.
You can no longer post new replies to this discussion. If you have a question you can start a new discussion

Inputing data through Serial Window is slow

Amr Henna

I am writing a code that simulates receiving text from the serial port using the serial window.
When I debug this code step by step and enter the text, it works fine, but when I run the code and enter the text all at once not all of the characters are received!
For example if I want to enter "OK", in debugging step by step I enter O then K and it is perfect. However, when I run the code and type "OK" quickly, I may receive "K" only or nothing at all, while if I type it slowly (which I don't think is the case in serial communication) it is received correctly!
Can you help me with this?
Thank You!

Parents
  • 0 in reply to Amr Henna

    "what is wrong with "break""
    OK i can remove the goto and put break instead? but this doesn't solve the problem!
    no, of course not, but it makes your code 'C' instead of "C coded assembler"

    "where does this wait for RI being set???"
    if it is set we take the input from the SBUF and then set the RI.

    there STILL is no wait for RI being set, your words do not change the code

    Erik

Reply
  • 0 in reply to Amr Henna

    "what is wrong with "break""
    OK i can remove the goto and put break instead? but this doesn't solve the problem!
    no, of course not, but it makes your code 'C' instead of "C coded assembler"

    "where does this wait for RI being set???"
    if it is set we take the input from the SBUF and then set the RI.

    there STILL is no wait for RI being set, your words do not change the code

    Erik

Children
  • 0 in reply to ²erik malund

    ""where does this wait for RI being set???"

    Here:

    while (RI==0);

    But it would be a whole lot easier to see if the OP took the trouble to properly lay out the code!

    And a few comments wouldn't go amiss; eg,

    while (RI==0); // Wait until RI is set

    Comments should also show what the OP intends the code to do - which will allow others to see any flaws in those expectations...

  • 0 in reply to Andy Neil

    Here:

    while (RI==0);
    But it would be a whole lot easier to see if the OP took the trouble to properly lay out the code!

    And a few comments wouldn't go amiss; eg,

    while (RI==0); // Wait until RI is set

    I missed that one because I (once? still?) work(ed) with a debugger that would not set a breakpount on

    while();

    but would set one on

    while()
{
}

    and thus since have 'outlawed' while();

    anyhow, the second form is a lot clearer

    of course, had the OP bothered to comment I would not have missed it.

    Erik

  • 0 in reply to ²erik malund

    More probably, you missed it because no "proper" code should have any actions performed to the right of an opening curly brace.

    With time, we learn pattern patching just as we learn speed-reading normal text based on patterns and not individual characters.

    Anyone posting code that isn't properly tagged and properly indented have waived their right to get any real help.

  • 0 in reply to ImPer Westermark

    Surely that's a privilege - not a right - anyhow...?