We are running a survey to help us improve the experience for all of our members. If you see the survey appear, please take the time to tell us about your experience if you can.
Hello,
I am removing all sprintf() function from my souce code as this function does not allow me to set the proper thread stack size. Does anyone have any function that implements this conversion?
Thanks Andre Moutinho
Hello, I have implemented a ftoa function and made some tests. What do you think? I have spent around 1 hour with tests.. Maybe I have missed something. The str array must be size 20.
void ftoa(float num, char *str) { int intpart = num; int intdecimal; int i; float decimal_part; char decimal[20]; memset(str, 0x0, 20); itoa(num, str, 10); strcat(str, "."); decimal_part = num - intpart; intdecimal = decimal_part * 1000000; if(intdecimal < 0) { intdecimal = -intdecimal; } itoa(intdecimal, decimal, 10); for(i =0;i < (PRECISION - strlen(decimal));i++) { strcat(str, "0"); } strcat(str, decimal); }
itoa(num, str, 10);
And what happens if num is 12345678? You really think a function named IntegerToAscii is up to the task?
Or what do you do if the number is 0.000000000000000012345678?
How do you then store the fractional part in an integer? Or make itoa() make a string of it? Or make the number fit in a 20-character array?
Also remember that sprintf() has more than one way to express a floating point value depending on the formatting string.
Here is the deal - if using sprintf(), you must care about the stack needs. If using own function to convert a floating point value, you must care about the size of the target buffer.
How much do you gain by not getting a stack overflow but instead a buffer overrun?
As Per mentioned there are a lot of things you are ignoring. I did give a strong HINT you should look at the EXISTING papers on this subject. It's not trivial the code your provided will work in narrow circumstances by the way (a lot of constraints). Perhaps you should define what you need to do before you go further? Also you may need to consider why you need to use sprintf in a thread separate from your primary thread.
I believe you need to DEFINE your problem not just write code. It makes things much easier for yourself and other people when you set constraints that reduce possible difficulties in implementation. In my case for writing something equivalent to sprintf floating point formatting it was for what Per mentioned, to prevent buffer overrun. sprintf does not perform buffer overrun check, thus I had to make a variant that in no way could have a buffer overrun.
You would be best served to do more research and planning on paper before you write any code. If you haven't defined your problem so that you can explain precisely and accurately what the constraints are "IE I can't use more than 128 bytes of stack space for this thread, this thread formats a double precision floating point for the user and places it on an LCD. The thread may not overrun the string buffer." etc etc. Those are constraints. Without specifications you are 'nailing jelly too a tree' (great book by the way).
Stephen
Hello Westermark, thanks for your reply.
Let me explain what I am doing first. My application is a module that has GPS and GPRS communication. I have a can interface and get some vehicle values such as speed, rotation, hodometer. The ftoa() function will be used only for debug of these values. I have checked their range and will be no larger than 2147483647 and not smaller than 0.00001.
Please read the answers bellow:
>And what happens if num is 12345678? You really think >a function named IntegerToAscii is up to the task?
Yes, it converted with success. Why an itoa() function will not convert this number? The ftoa() function returned 12345678.00000. 12345678 < 2147483647 (0x7ffffff)
>Or what do you do if the number is >0.000000000000000012345678?
This will result in 0.00. But this value is out of the range precision I have stabilished. The result was 0.00000. Thats OK once I have stablished 6 digits of precision.
>How do you then store the fractional part in an >integer?
By multiplying for the precision I want. If I want 0.00001 I then multiply it for 100000.
>Or make itoa() make a string of it? >Or make the number fit in a 20-character array?
Limiting the higher value and precision. I have forgotten to limit the higher value. Will do it.
>Also remember that sprintf() has more than one way to >express a floating point value depending on the >formatting string.
Will not need this.
>Here is the deal - if using sprintf(), you must care >about the stack needs. If using own function to >convert a floating point value, you must care about >the size of the target buffer.
Yes, correct. I will narrow the higher value to 2147483647 (0x7FFFFFFF) or 10 digits. The decimal part in constrained to 5 digits. More one for the '.' and an extra 0x0 for final termination. Total used will be 17 characteres and no buffer overrun.
>How much do you gain by not getting a stack overflow >but instead a buffer overrun?
Nothing, but creating such constraints that works 100% in my application I eliminated both problems.
Regards, Andre
Hello Stephen,
Please read my previous reply. My application has more than 20 task and each task must have debug.
If you haven't debugged anything under an RTOS then I suggest you get some advice. Printfs in 20 different threads to debug your code is inadvisable and not likely to help you remain sane. It's difficult enough trying to debug something with a single thread but 20 is asking for serious trouble if you don't have a VERY well defined method.
Break it down. Test each thread's code with all of it's possible states of error individually. This is not far fetched as I mentioned I wrote my own variant of printf, I had to guarantee that it WORKED correctly EVERY time and gave the correct answer EVERY time irregardless of what was thrown at it. I performed float point prints from -9999.99 to 9999.99 in 0.001 increments to verify it worked correctly (yes 2 million tests), and then -999.999 to 999.999 (another 2 million tests). That covers single precision floating points significant digits and all digits that would possibly be used. THEN I had to test out of range values and illegal floating point values etc. (generating random integers and type casting them as floats as well).
This is a simple unit test. The specs are in the test itself (number ranges and digit count).
You should do this amount of testing too each thread individually to insure that by itself (or 2 threads if it needs another to feed data too it etc) it works correctly.
Printf on everything tends to just confuse things, and if you have 20 sources of debug data then you have 2^20 times the amount of possible confusion (binary joke had to be done).
Once you have guaranteed each part of your program works correctly and leaves no unknown states the rest is relatively easy.