This discussion has been locked.
You can no longer post new replies to this discussion. If you have a question you can start a new discussion

Electronic Display Board with 4" inches

Well I have just finished a project that for an electronic board, which will serve for the indication of tank mixing and production lines in a company here in my country, the project fairly economical with regard to buy the board already done.

* 2 x 20 LCD display for the data entered

* Keyboard 4 x 4 matrix for entry operator

* 80C52FA and brain.

* 80C52FA and brain.

* Siren for the indication has been received that a change

* 8 display 7 segments 4"

Hen I planted the project, the question i hav is menera making each separate part of the plate code and the party power to the union used straps with IDC connectors 20 and 10 pin terminals besides 2 to coneciones supply and alarm.

void main( void )
{
  getkeyvalue ();

  checklevel ();

  outputnumber ();

  main ();
}


Greetings to all and thanks to you all

Parents
  • First off: Is there a question hidden somewhere in your post?

    Secondly: Don't call main() from main(). What is wrong with a simple loop? You do not know exactly how the compiler will generate the main() function prologe/epiloge and if the compiler will detect tail-end recursion. If your code works now, that doesn't prove that a newer compiler version may change it's behaviour.

    Thirdly: Watch out for descriptive function names. It isn't obvious if getkeyvalue() will just check if any key has been pressed, or if it will wait until a key has been pressed. The behaviour of the program will change completely depending on these two alternatives... If it does not wait, it might be better to write checkkeyboard() or something. At least for me, getkeyvalue() give a very strong indication that the program will hang in the function call.

Reply
  • First off: Is there a question hidden somewhere in your post?

    Secondly: Don't call main() from main(). What is wrong with a simple loop? You do not know exactly how the compiler will generate the main() function prologe/epiloge and if the compiler will detect tail-end recursion. If your code works now, that doesn't prove that a newer compiler version may change it's behaviour.

    Thirdly: Watch out for descriptive function names. It isn't obvious if getkeyvalue() will just check if any key has been pressed, or if it will wait until a key has been pressed. The behaviour of the program will change completely depending on these two alternatives... If it does not wait, it might be better to write checkkeyboard() or something. At least for me, getkeyvalue() give a very strong indication that the program will hang in the function call.

Children
No data