This discussion has been locked.
You can no longer post new replies to this discussion. If you have a question you can start a new discussion

Problems with linked list and xdata

I'm having a problem getting a linked list to work on Keil. I'm using an aduc842 microcontroller from Analog. Linked lists are something we do all the time in c and i'm baffled as to why i cant get it to work in this situation. This code works in the simulator but doesnt work on the actual hardware. Ive got 2k on chip xdata and it's configured as such. Ive tried using void * as well for the link node, which increases the size of the struct by one byte, and that didnt work either.

#include <ADuC842.h>
sbit led = 0xb4;
unsigned char xdata Store[1024] ;
unsigned char xdata * pStore ;
void xdata *  FetchMem ( unsigned int bytes ) {
	unsigned char xdata * ppStore ;
	ppStore = pStore ;
	pStore += bytes ;
	return ppStore ;
}

xdata struct Example {
	unsigned char a ;
	struct Example xdata * Next ;
} ;
struct Example xdata List ;
struct Example xdata * pList ;
int main (void ){
	unsigned char i ;
	FetchMem(1);
	pList=&List ;
	pList->a='a'; pList->Next = 0 ;
	{
		struct Example xdata * rec ;
		rec=FetchMem(sizeof(struct Example));
		rec->a='b'; rec->Next=0;
		pList->Next=rec; pList=rec;}
	{
		struct Example xdata * rec ;
		rec=FetchMem(sizeof(struct Example));
		rec->a='c'; rec->Next=0;
		pList->Next=rec; pList=rec;
	}
	{
		struct Example xdata * rec ;
		rec=FetchMem(sizeof(struct Example));
		rec->a='d'; rec->Next=0;
		pList->Next=rec; pList=rec;
	}
	pList=&List;
	for(;;){
		i=pList->a;
		if(pList->Next==0)break;
		pList=pList->Next;
	}
	led=!led;
	for(;;){}
}

Parents
  • Linked lists are something we do all the time in c and i'm baffled as to why i cant get it to work in this situation
    Because "the '51 aint no PC". What you "do all the time in c" may and may not fit the '51 architecture.

    sure, you can "get it to work" but that does not make it right. If you just took one small peek at the code, the use of linked lists, generate with the '51 architecture you would immediately stop using the combination.

    If you have to violate the poor little controller, go ahead and fix/have fixed your code, but why do you have to ignore what you are working with.

    Erik

Reply
  • Linked lists are something we do all the time in c and i'm baffled as to why i cant get it to work in this situation
    Because "the '51 aint no PC". What you "do all the time in c" may and may not fit the '51 architecture.

    sure, you can "get it to work" but that does not make it right. If you just took one small peek at the code, the use of linked lists, generate with the '51 architecture you would immediately stop using the combination.

    If you have to violate the poor little controller, go ahead and fix/have fixed your code, but why do you have to ignore what you are working with.

    Erik

Children
  • Because "the '51 aint no PC". What you "do all the time in c" may and may not fit the '51 architecture.

    sure, you can "get it to work" but that does not make it right. If you just took one small peek at the code, the use of linked lists, generate with the '51 architecture you would immediately stop using the combination.


    Ive put a lot of thought into my design. Using a few linked lists in xdata is actually the most efficient use of memory in my situation. Yes, even on the little ol' 51'. And no, i'm not using malloc, and yes i'm quite aware of the difference between the '51 and ia32.

    So my problem is that i can assign the next pointer to point to another structure, but when i follow it, it takes me off into the weeds. The code works fine in the simulator, but it doesnt work on the actual hardware. I have 64k of memory on the real hardware. The size of the pointer to the struct is 2 bytes. Ive verified that i can read and write bytes in xdata and that memory settings are correct. Ive been at this for days, i'm frustrated beyond beleif.