This discussion has been locked.
You can no longer post new replies to this discussion. If you have a question you can start a new discussion

Problem with interrup on P89C557E4

Hi, i'm having a problem with the interrupt routine for timer 0 on the P89C557E4 Philips chip.
The interrupt routine doesn't work when running the program. when i simulate it, it works fine.
below is the code:

#include <reg557.h>
#define TIMER0_COUNT 0xDC11 /* 10000h - ((11,059,200 Hz / (12 * FREQ)) - 17) */
static unsigned timer0_tick; /* timer tick variable */
/*------------------------------------------------------------------------------
static void timer0_isr (void);
This function is an interrupt service routine for TIMER 0. It should never
be called by a C or assembly function. It will be executed automatically
when TIMER 0 overflows.
------------------------------------------------------------------------------*/
static void timer0_isr (void) interrupt 1 using 1
{
/*------------------------------------------------
Stop Timer 0, adjust the timer 0 counter so that
we get another interrupt in 10ms, and restart the
timer.
------------------------------------------------*/
TR0 = 0; /* stop timer 0 */
TL0 = TL0 + (TIMER0_COUNT & 0x00FF);
TH0 = TH0 + (TIMER0_COUNT >> 8);
TR0 = 1; /* start timer 0 */
/*------------------------------------------------
Increment the timer tick. This interrupt should
occur approximately every 10ms. So, the resolution
of the timer will be 100Hz not including interrupt
latency.
------------------------------------------------*/
//timer0_tick++;
CMSR4 = 0;
}
/*------------------------------------------------------------------------------
void timer0_initialize (void);
This function enables TIMER 0. TIMER 0 generates a synchronous interrupt
once every 100Hz.
------------------------------------------------------------------------------*/
void timer0_initialize (void)
{
EA = 0; /* disable interrupts */
timer0_tick = 0;
TR0 = 0; /* stop timer 0 */
TMOD &= ~0x0F; /* clear timer 0 mode bits */
TMOD |= 0x01; /* put timer 0 into 16-bit no prescale */
TL0 = (TIMER0_COUNT & 0x00FF);
TH0 = (TIMER0_COUNT >> 8);
PT0 = 0; /* set low priority for timer 0 */
ET0 = 1; /* enable timer 0 interrupt */
TR0 = 1; /* start timer 0 */
EA = 1; /* enable interrupts */
}
/*------------------------------------------------------------------------------
unsigned timer0_count (void);
This function returns the current timer0 tick count.
------------------------------------------------------------------------------*/
unsigned timer0_count (void)
{
unsigned t;
EA = 0;
t = timer0_tick;
EA = 1;
return (t);
}
/*------------------------------------------------------------------------------
void timer0_delay (
unsigned count);
This function waits for 'count' timer ticks to pass.
------------------------------------------------------------------------------*/
void timer0_delay (
unsigned count)
{
unsigned start_count;
start_count = timer0_count (); /* get the starting count */
while ((timer0_count () - start_count) <= count) /* wait for count "ticks" */
{
}
}
void main (void)
{
timer0_initialize();
while (1)
  {
CMSR4 = !CMSR4;
//timer0_delay( 1 );
  }
}

thank you for any help you can provide me.

Parents
  • The position of the timer handler routine is not your problem --- the actual handler is not supposed to be positioned at 0x000b (not 0x0003) in code memory. Only a jmp to the handler has to be there, and apparently it is
    That is right!
    since you said that the timer0_counter variable is being incremented as designed
    Hans, it is NOT being incremented, it is only when in debug mode.
    Did you try my suggestion about making that volatile?
    How do I do that? I took the static keyword off. Still doesn't work. But notice that TF0 is not being cleared, what means that the ISR is not being called.
    I looked at the hex file, and it seemed alright, so I asked people from Philips.
    Here is the first lines of the hex:

    :03000B00020826C2
    :10082600C0E0C0D0C28C7411258AF58A74DC258C90
    :10083600F58CD28C0509E50970020508D0D0D0E008
    :01084600327F
    
    the 1st places a LJMP to 0826 at 000B
    the 2nd and 3rd put the routine starting at 0826
    the 4th is a RETI
    That is, I think, exactly what it should be, so I can't figure out where the problem is.
    Thank you.

Reply
  • The position of the timer handler routine is not your problem --- the actual handler is not supposed to be positioned at 0x000b (not 0x0003) in code memory. Only a jmp to the handler has to be there, and apparently it is
    That is right!
    since you said that the timer0_counter variable is being incremented as designed
    Hans, it is NOT being incremented, it is only when in debug mode.
    Did you try my suggestion about making that volatile?
    How do I do that? I took the static keyword off. Still doesn't work. But notice that TF0 is not being cleared, what means that the ISR is not being called.
    I looked at the hex file, and it seemed alright, so I asked people from Philips.
    Here is the first lines of the hex:

    :03000B00020826C2
    :10082600C0E0C0D0C28C7411258AF58A74DC258C90
    :10083600F58CD28C0509E50970020508D0D0D0E008
    :01084600327F
    
    the 1st places a LJMP to 0826 at 000B
    the 2nd and 3rd put the routine starting at 0826
    the 4th is a RETI
    That is, I think, exactly what it should be, so I can't figure out where the problem is.
    Thank you.

Children