• State Not Answered
  • Locked Locked
  • Replies 7 replies
  • Subscribers 21 subscribers
  • Views 2949 views
  • Users 0 members are here
2025 survey

We are running a survey to help us improve the experience for all of our members. If you see the survey appear, please take the time to tell us about your experience if you can.

Options
Related
How was your experience today?
This discussion has been locked.
You can no longer post new replies to this discussion. If you have a question you can start a new discussion

Include Files Problem

Yaswanth Narvaneni

Hi Friends,
I'm currently working on C51v6.02 by Keil, My Problem goes like this:

I have a project which has the files file1.c, file2.c, file3.c. And header files header1.h, header2.h, header3.h. The source code of file1.c goes like this.

#include "header1.h"
#include "header2.h"

/* My code */
The source code of file2.c goes like this.

#include "header1.h"
#include "header3.h"

/* My code */
Now when I compile the project the following error message creeps in

*** ERROR L104: MULTIPLE PUBLIC DEFINITIONS
    SYMBOL:  VARIABLE_NAME
    MODULE:  File_Name.obj  (FILE_NAME)

My header file header1.h goes this way
#ifndef __HEADER1_H__
#define __HEADER1_H__

/* My Code */
/* Also includes variables */

#endif

but still the same error creeps in. Is there any way to avoid this? What ever I'm doing, is it the corrent way to do it?? Thank you.

With Regards,
Yaswanth

 Proudly wasting time since 1981

  • 0

    you probably have some name (see error message) included in all header files. This often happens when the .h includes another .h

    Erik

  • 0

    Yaswanth:

    I do not see anything wrong with what you are doing. I use the same scheme as you with all my projects.

    Is it possible that you are using variable names longer than 32 characters? They can be 256 character long but only the first 32 characters are significant (at least for C166). Just a wild guess.

    -Walt

  • 0

    Make sure you only have external declarations in your header files and not any defining declarations (i.e., space-allocating). Defining declarations only belong in ".c" files.

  • 0 in reply to Dan Henry

    The message tells you the name of the symbol with the multiple definitions; use that to search all your files & spot the repeats!

    The duplicates may not necessarily be in the headers

    I think I've criticised this message before: it's fairly pointless of it to complain about multiple definitions, but then only list one module name!

    Borland C++ Builder would list all the files which defined the offending symbol, thus making your search much easier!

  • 0 in reply to Andy Neil

    Borland C++ Builder would list all the files which defined the offending symbol, thus making your search much easier!

    Oh well, you would do a global search in CodeWright anyhow to find the actual places.

    Erik

  • 0 in reply to erik malund

    You can use the Linker IXREF directive to figure out which module the symbol already defines. This option is enabled under uVision2 - Project - Options for Target - Listing - Linker - Cross Reference.

  • 0 in reply to Keil Support Intl.

    I'm sure you can; but my point is that you shouldn't have to!
    The Linker knows the information, so why doesn't it include it in the message?!!
    eg
    *** ERROR L104: MULTIPLE PUBLIC DEFINITIONS
    SYMBOL: VARIABLE_NAME
    MODULE: File_Name1.obj (FILE_NAME)
    MODULE: File_Name2.obj (FILE_NAME)

    As I've said before, Borland does it like this.

    What is the point of saying that it's detected multiple definitions, but then only listing one of them!